summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJason Kim <git@jasonk.me>2021-04-09 00:10:27 -0700
committerJason Kim <git@jasonk.me>2021-04-09 00:16:05 -0700
commit905abce8f778e9a3edbd69b9f3183c93d11edffa (patch)
treee6248a35556dcf70ff7724b2b903cf51c0f2e5a8
parente86895b00882d900e9d828a852df54d87211c988 (diff)
downloadprivacy-redirect-905abce8f778e9a3edbd69b9f3183c93d11edffa.tar.gz
privacy-redirect-905abce8f778e9a3edbd69b9f3183c93d11edffa.tar.bz2
privacy-redirect-905abce8f778e9a3edbd69b9f3183c93d11edffa.zip
refactor: drop teddit image redirect support
No longer redirect image links for teddit instances. Add a comment detailing the two issues I found. Now, the feature should be stable.
-rw-r--r--src/pages/background/background.js8
1 files changed, 6 insertions, 2 deletions
diff --git a/src/pages/background/background.js b/src/pages/background/background.js
index 2534279..2047bfb 100644
--- a/src/pages/background/background.js
+++ b/src/pages/background/background.js
@@ -452,8 +452,12 @@ function redirectReddit(url, initiator, type) {
if (redditInstance.includes("libredd")) {
return `${redditInstance}/img${url.pathname}${url.search}`;
} else if (redditInstance.includes("teddit")) {
- let pathWithoutSlash = url.pathname.slice(1);
- return `${redditInstance}/pics/w:null_${pathWithoutSlash}${url.search}`
+ // As of 2021-04-09, redirects for teddit images are nontrivial:
+ // - navigating to the image before ever navigating to its page causes
+ // 404 error (probably needs fix on teddit project)
+ // - some image links on teddit are very different
+ // Therefore, don't support redirecting image links for teddit.
+ return null;
} else {
return null;
}
title='2021-01-11 19:00:26 +0300'>2021-01-11Update messages.jsonTotalCaesar659 2021-01-11Update Russian translationTotalCaesar659 2021-01-11Fix typoSimonBrazell 2021-01-11CLoses #130 changed to GPLv3, added SearX instances (#16), fixed instance ↵v1.1.45SimonBrazell selects. 2021-01-11gecko: strict_min_version: 67.0 due to dynamic importsSimonBrazell 2021-01-11Fix for https://github.com/mozilla/addons-linter/issues/3541#issue-782801439SimonBrazell 2021-01-10Fixed README & build configv1.1.44SimonBrazell 2021-01-10Restructure code with helper modules, add search engine settings, & advanced ↵SimonBrazell settings collapsibles. 2021-01-05Added more instances of teddit and libredditSoheb 2021-01-05Add support for libredd.itSoheb 2020-12-26Losslessly compress PNG imagesFrank3K 2020-12-17add nitter.unixfox.eu as a nitter instance to the listEmilien Devos 2020-11-29Update background.jsAustin Huang 2020-11-22Updated background.jsaapl-yumi 2020-11-17Add "yewtu.be" back to the random instance listÉmilien Devos 2020-11-11Update background.jsYumi Izumi 2020-11-09Update Russian translationTotalCaesar659 2020-11-09Update README.mdYumi Izumi 2020-11-09Update options.jsYumi Izumi 2020-11-09Update options.htmlYumi Izumi 2020-11-08Update popup.jsYumi Izumi 2020-11-08Update popup.htmlYumi Izumi 2020-11-08Update background.jsYumi Izumi 2020-11-08Closes #111 - Adds ability to customise random instance poolsv1.1.43SimonBrazell 2020-11-08Fixes #119 - Change zh-CN to zh_CN.SimonBrazell 2020-11-07Update README.mdKunio Some suggestions, added FreeTube, updated invidious links, added permissions. 2020-11-05Update Russian translationTotalCaesar659 2020-11-04Update store listing templatesSimonBrazell 2020-11-04Update Bibliogram linksbopol Bibliogram has moved to source hut (for a while now) 2020-11-04Remove duplicate entry in instagramReservedPaths arraySimonBrazell 2020-11-04Remove "https://yewtu.be" from random instance listSimonBrazell 2020-11-04Ignore embedded videos for FreeTube redirectsSimonBrazell 2020-11-04Fixes #99 - Bibliogram, handle /igtv/, /tv/ and /reel/v1.1.42SimonBrazell 2020-11-04Fixes #104 - /remove-twitter-sw.js stopping Twitter redirectsSimonBrazell 2020-11-04Closes #113 - Added support for FreeTubeSimonBrazell 2020-11-04Clean up invidious random instance listSimonBrazell 2020-10-23Rename _locales/store.md to _locales/pl/store.mdAustin Huang